Add comprehensive unit tests across all modules#10
Merged
Conversation
Establishes foundational test coverage for pgrsql as outlined in issue #8. Adds inline #[cfg(test)] modules to 6 existing source files covering editor buffer operations, query history, theme/syntax detection, database connection config, query result types, and schema introspection. Closes #8 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Establishes foundational test coverage for pgrsql, addressing the testing strategy outlined in #8. Adds 124 unit tests across all 6 existing source modules using inline
#[cfg(test)]modules.Test Coverage by Module
src/editor/buffer.rs— 50 testsnew(),Default,from_text()(empty, single-line, multi-line)text(),current_line(),line_count()src/editor/history.rs— 20 testssrc/ui/theme.rs— 20 testssrc/db/connection.rs— 18 testsquote_conn_value(), base64 decoding (with padding, without, with newlines)src/db/query.rs— 12 testssrc/db/schema.rs— 8 testsDesign Decisions
#[cfg(test)]modules — tests live alongside the code they test, following Rust conventioncargo clippycleanlyTest Results
Test plan
cargo test— 124 tests passcargo clippy— zero warningscargo fmt— properly formattedCloses #8
🤖 Generated with Claude Code